Support for re-authentication #492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GreenStage , thanks for the PR, I see that the motivation for this is to eventually support OAUTH but I'm not sure if it makes sense to add support for re-authentication yet if there isn't anything implemented that uses it (If the intention is to leave this open until someone takes up implementing OAUTH then that's cool too, just trying to figure out if you wanted to have this merged earlier) |
|
Hi @nlsun , I was waiting for this one to be merged before opening a new PR. Shall i join the code for oauth in this PR? |
|
Ah that's great, i think it would make sense to open a separate PR that depends on this one |
|
@GreenStage did you still want to submit the follow-up PR? |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes an implementation of client-side support for periodic re-authentication, as defined here
Note that this functionality is needed in order to properly support SASL/OAUTHBEARER authentication
Protocol reference: http://kafka.apache.org/protocol.html#sasl_handshake