Skip to content

Update CSVHandler to accept additional options when reading and writing #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pvk-developer
Copy link
Member

Resolves #2478
CU-86b4r2yh7

@sdv-team
Copy link
Contributor

sdv-team commented May 5, 2025

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (e8921f9) to head (cca3399).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2502   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          59       59           
  Lines        6234     6236    +2     
=======================================
+ Hits         6147     6149    +2     
  Misses         87       87           
Flag Coverage Δ
integration 82.55% <85.71%> (+0.03%) ⬆️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pvk-developer pvk-developer force-pushed the issue-2478-allow-me-to-put-in-additional-options-when-reading-multiple-csv-files-from-csvhandler branch from c2b1869 to 885e225 Compare May 5, 2025 10:36
@pvk-developer pvk-developer self-assigned this May 5, 2025
@pvk-developer pvk-developer marked this pull request as ready for review May 5, 2025 10:36
@pvk-developer pvk-developer requested a review from a team as a code owner May 5, 2025 10:36
@pvk-developer pvk-developer requested review from amontanez24 and frances-h and removed request for a team May 5, 2025 10:36
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One comment then :shipit:

@pvk-developer pvk-developer merged commit f6570e1 into main May 6, 2025
45 checks passed
@pvk-developer pvk-developer deleted the issue-2478-allow-me-to-put-in-additional-options-when-reading-multiple-csv-files-from-csvhandler branch May 6, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow me to put in additional options when reading multiple CSV files from CSVHandler
4 participants