Making the mono module no-op unless the mono runtime is present

[glennblock]

Fix for #1

Requires: scriptcs/scriptcs#635 to be merged first.

[adamralph]

This is mostly for my education, but why do we no longer need to set the extension?

[glennblock]

We want the REPL to just work so it needs to load the module all the time as there is no extension it can look for. We don't want people to have to specify the mono module, it should just work.

One thing you did make me realize (thanks) however is that the module should only register an engine IF one was not already registered.

I've added an conditional check for this module and the new Roslyn Module that will only register IF no other engine has already been provided. This way the F# module etc will still work and not be overridden. Order also doesn't matter, because let's say the F# module loads first, then it will register itself and not be overridden. If the Roslyn/Mono module is registered first then it will be overridden.

Make sense?

[adamralph]

Thanks, makes sense.

[adamralph]

Oh, I was going to merge this but I don't have the right permissions in the scriptcs-contrib org.

[glennblock]

Contrib projects are up to the owner (@filipw in this case) of each project to add who they want.

[filipw]

I agree with the idea (after all, we discussed it) - but what if I want to run the mono.csharp engine on windows? (i.e. for dynamic etc). it wouldn't be possible now.

It feels like it would make sense to push the args to the modules so that there can be some switch or something like that.

[glennblock]

It should work. If you run with the mono runtime it will use the mono
engine.

On Mon, Apr 21, 2014 at 11:26 PM, Filip W [email protected] wrote:

I agree with the idea (after all, we discussed it) - but what if I want to
run the mono.csharp engine on windows? (i.e. for dynamic etc). it
wouldn't be possible now.

It feels like it would make sense to push the args to the modules so that
there can be some switch or something like that.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-41007617
.

[glennblock]

So on Windows, I run with the mono runtime to get the mono engine, if I run
with the standard .net engine (i.e. just run scriptcs.exe directly) it uses
the .NET engine. There's no value in the switch as it's the runtime that
determines which engine will be usable.

On Mon, Apr 21, 2014 at 11:27 PM, Glenn Block [email protected] wrote:

It should work. If you run with the mono runtime it will use the mono
engine.

On Mon, Apr 21, 2014 at 11:26 PM, Filip W [email protected]:

I agree with the idea (after all, we discussed it) - but what if I want
to run the mono.csharp engine on windows? (i.e. for dynamic etc). it
wouldn't be possible now.

It feels like it would make sense to push the args to the modules so that
there can be some switch or something like that.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-41007617
.

[glennblock]

Sorry I mean if I run with the standard .NET runtime by just running
scriptcs.exe it uses the .NET engine.

On Mon, Apr 21, 2014 at 11:28 PM, Glenn Block [email protected] wrote:

So on Windows, I run with the mono runtime to get the mono engine, if I
run with the standard .net engine (i.e. just run scriptcs.exe directly) it
uses the .NET engine. There's no value in the switch as it's the runtime
that determines which engine will be usable.

On Mon, Apr 21, 2014 at 11:27 PM, Glenn Block [email protected]:

It should work. If you run with the mono runtime it will use the mono
engine.

On Mon, Apr 21, 2014 at 11:26 PM, Filip W [email protected]:

I agree with the idea (after all, we discussed it) - but what if I want
to run the mono.csharp engine on windows? (i.e. for dynamic etc). it
wouldn't be possible now.

It feels like it would make sense to push the args to the modules so
that there can be some switch or something like that.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-41007617
.

[glennblock]

See this screenshot from here (http://mono-project.com/Using_Mono_on_Windows)
get my point:

[image: Inline image 1]

If you run scriptcs.exe using mono i.e. mono scriptcs.exe then the mono
types will be avail and the mono engine will be registered.

On Mon, Apr 21, 2014 at 11:29 PM, Glenn Block [email protected] wrote:

Sorry I mean if I run with the standard .NET runtime by just running
scriptcs.exe it uses the .NET engine.

On Mon, Apr 21, 2014 at 11:28 PM, Glenn Block [email protected]:

So on Windows, I run with the mono runtime to get the mono engine, if I
run with the standard .net engine (i.e. just run scriptcs.exe directly) it
uses the .NET engine. There's no value in the switch as it's the runtime
that determines which engine will be usable.

On Mon, Apr 21, 2014 at 11:27 PM, Glenn Block [email protected]:

It should work. If you run with the mono runtime it will use the mono
engine.

On Mon, Apr 21, 2014 at 11:26 PM, Filip W [email protected]:

I agree with the idea (after all, we discussed it) - but what if I want
to run the mono.csharp engine on windows? (i.e. for dynamic etc). it
wouldn't be possible now.

It feels like it would make sense to push the args to the modules so
that there can be some switch or something like that.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-41007617
.