fix: regression causing a crash in embedded studios #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christianhg
previously approved these changes
May 8, 2024
stipsan
force-pushed
the
fix-regression-causing-a-crash-in-embedded-studios
branch
from
b3952cc to
1401de4
Compare
christianhg
approved these changes
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In embedded Studios the
previewUrloption typically won't haveoriginspecified, leading to a crash:Tested this fix on sanity-io/nextjs-blog-cms-sanity-v3#505
I would write a test for it but I feel we should fast track a fix and ask Studio DX to do a patch of
sanityand circle back later instead, since everyone on embedded studios are currently unable to use Presentation Tool 😅