Skip to content

style(test): clarify uses of snapbox::str![] #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented May 20, 2025

Part of #4359, addresses #4334 (comment).

To make the origin of the str![[r#"..."#]] special syntax clearer, the current implementation qualifies all uses of snapbox::str![].

@rami3l rami3l requested a review from djc May 20, 2025 15:49
@rami3l rami3l changed the title style(test): qualify uses of snapbox::str![] style(test): clarify uses of snapbox::str![] May 20, 2025
@rami3l rami3l enabled auto-merge May 20, 2025 16:09
@rami3l rami3l added this pull request to the merge queue May 20, 2025
Merged via the queue into rust-lang:master with commit 6f630cf May 20, 2025
29 checks passed
@rami3l rami3l deleted the style/qualify-snapbox-str branch May 20, 2025 16:41
FranciscoTGouveia added a commit to FranciscoTGouveia/rustup that referenced this pull request May 26, 2025
This change is done to be consistent with the new migration to the
`.expect()` API's that were defined in rust-lang#4334 and rust-lang#4342, and are
showcased in the latest PR for migration (rust-lang#4343).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants