Skip to content

zombie_processes: do not complain about early early returns #14912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented May 28, 2025

If an early return is found under the HIR local declaration node but before the child process is created, it should not trigger the lint because the child process has not yet been created.

changelog: [zombie_process]: do not complain about early early returns

Fixes #14911

If an early return is found under the HIR local declaration node but
before the child process is created, it should not trigger the lint
because the child process has not yet been created.
@rustbot
Copy link
Collaborator

rustbot commented May 28, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 28, 2025
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Jun 3, 2025
Merged via the queue into rust-lang:master with commit 716eadf Jun 3, 2025
13 of 15 checks passed
@samueltardieu samueltardieu deleted the issue-14911 branch June 3, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"spawned process is not wait()ed on in all code paths" when ? used in chain call before spawn()
3 participants