Skip to content

WIP: use ui_test dependency builder for test dependencies #14883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 24, 2025

changelog: none

This tries to make progress on rust-lang/rust#78717 by using the ui_test dependency handling instead of linking in the dependencies of clippy itself with the tests. This effectively reverts #11045.

However, it doesn't quite work. I am getting this:

command: Ok(
    (
        "quote",
        [
            "/home/r/src/rust/clippy/target/ui_test/0/debug/deps/libquote-7d753679308ff16a.rlib",
            "/home/r/src/rust/clippy/target/ui_test/0/debug/deps/libquote-7d753679308ff16a.rmeta",
        ],
    ),
) vs Ok(
    (
        "quote",
        [
            "/home/r/src/rust/clippy/target/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-d21625b54f8de8ce.rlib",
            "/home/r/src/rust/clippy/target/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-d21625b54f8de8ce.rmeta",
        ],
    ),
) (["lib"])

full stderr:
registry+https://github.com/rust-lang/crates.io-index#[email protected]
full stdout:
`ui_test` does not support crates that appear as both build-dependencies and core dependencies

I am not sure which exact dependencies ui_test is referring to here -- clippy_test_deps does not have any build-dependencies.

@oli-obk do you know what could be done here?

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 24, 2025
@RalfJung RalfJung marked this pull request as draft May 24, 2025 09:34
@Alexendoo
Copy link
Member

No clue about the ui_test error, but ui-internal tests still depend on clippy_utils

@RalfJung
Copy link
Member Author

Oh I see, and those are driven by the same runner. So depending on the test suite we'll need to use one or the other logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants