Optimize documentation lints **a lot** (2/2) (7.5% -> 1%) #14870
+54
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
blyxyas
force-pushed
the
optimize-doc-lints-electric-bogaloo
branch
2 times, most recently
from
61f5c20 to
58e4574
Compare
blyxyas
changed the title
Jarcho
approved these changes
May 23, 2025
blyxyas
force-pushed
the
optimize-doc-lints-electric-bogaloo
branch
from
58e4574 to
71090fe
Compare
So, after rust-lang#14693 was merged, this is the continuation. It performs some optimizations on `Fragments::span` , makes it so we don't call it so much, and makes a 85.75% decrease (7.51% -> 10.07%) in execution samples of `source_span_for_markdown_range` and a 6.39% -> 0.88% for `core::StrSearcher::new`. Overall a 13.11% icount decrase on docs-heavy crates. Benchmarked mainly on `regex-1.10.5`. This means that currently our heaviest function is `rustc_middle::Interners::intern_ty`, even for documentation-heavy crates Co-authored-by: Roope Salmi <[email protected]>
blyxyas
force-pushed
the
optimize-doc-lints-electric-bogaloo
branch
from
71090fe to
4a7598f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, after #14693 was merged,
this is the continuation. It performs some optimizations on
Fragments::span, makes it so we don't call it so much, and makes a 85.75% decrease (7.51% -> 1.07%)
in execution samples of
source_span_for_markdown_rangeand a 6.39% -> 0.88%for
core::StrSearcher::new. Overall a 13.11% icount decrase on docs-heavy crates.Benchmarked mainly on
regex-1.10.5.@rustbot label +performance-project
This means that currently our heaviest function is
rustc_middle::Interners::intern_ty, evenfor documentation-heavy crates
Along with #14693, this makes the lint a 7% of what it was before and makes it so that even in the most doc-heavy of crates it's not an issue.
changelog:Optimize documentation lints by a further 85%
r? @Jarcho