needless_return: look inside else if parts as well
#14798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Writing PRs from Rust Week? |
|
Testing the PR review limit r? ghost |
|
Failed to set assignee to
|
|
r? blyxyas |
blyxyas
requested changes
May 22, 2025
| return 3; | ||
| //~^ needless_return | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you add some weirded expressions, for future proofing (and checking that it works correctly right now)
Suggested change
| } | |
| fn test4(a: i32) -> u32 { | |
| if a == 0 { | |
| return 1; | |
| } else if if if a > 0x1_1 { | |
| return 2; | |
| } else { | |
| return 5; | |
| } {true} else { true } { 0xDEADC0DE } | |
| else if match a { b @ _ => { return 1; } } | |
| { 0xDEADBEEF } | |
| else { 1 } | |
| } | |
| } |
rustbot
added
S-waiting-on-author
`if` expressions don't necessarily contain a block in the `else` part in the presence of an `else if`. The `else` part, if present, must be handled as a regular expression, not necessarily as a block expression.
samueltardieu
force-pushed
the
else-if-return
branch
from
bd52c01 to
c364717
Compare
|
Done. Only the first |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifexpressions don't necessarily contain a block in theelsepart in the presence of anelse if. Theelsepart, if present, must be handled as a regular expression, not necessarily as a block expression.Found while applying Clippy to triagebot and looking at the result. This also found an issue in Clippy itself.
changelog: [
needless_return]: look insideelse ifparts as well