Skip to content

Read PR body from event in clippy_changelog action #14736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Read PR body from event in clippy_changelog action #14736

merged 1 commit into from
May 5, 2025

Conversation

Alexendoo
Copy link
Member

Simplifies the implementation a bit, also makes the message an error annotation

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 5, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 5, 2025
@Alexendoo Alexendoo force-pushed the changelog-action branch from 503baeb to 4142ed7 Compare May 5, 2025 15:30
@Alexendoo Alexendoo force-pushed the changelog-action branch from 4142ed7 to e21b936 Compare May 5, 2025 15:31
flip1995
flip1995 approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way simpler! I hope the PR body thing is "new" and not something I missed a long time ago 😅

@flip1995 flip1995 added this pull request to the merge queue May 5, 2025
Merged via the queue into rust-lang:master with commit f60d7f9 May 5, 2025
11 checks passed
@Alexendoo Alexendoo deleted the changelog-action branch May 5, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexendoo @rustbot @flip1995