Prepare to split clippy_lints
#14684
Conversation
rustbot
added
the
S-waiting-on-review
|
Thanks for assigning me to those PRs and requesting my review! However, I can't keep up with my reviews. I suggest Alex as the main reviewer, maybe with the help of Samuel. I fully trust you that you'll improve our tooling here! If you really want my review, just keep me assigned and I'll see what I can do this weekend. Otherwise, feel free to re-assign those PRs to Alex and/or Samuel. (applies to all clippy_dev PRs currently open, just commenting once here) |
|
I only assigned you to this one since splitting will (maybe) affect the sync in an annoying way. edit: Just rerolled the others. |
Jarcho
added
the
S-blocked
clippy_dev/src/update_lints.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn crate_root_path(self) -> &'static str { |
There was a problem hiding this comment.
NIT: Maybe a better name crate_lib_path or even more explicit crate_lib_rs_path.
No strong opinion here though.
There was a problem hiding this comment.
I'll leave this for when I end up having to rebase. Hopefully I don't forget.
This comment has been minimized.
This comment has been minimized.
|
When should this PR be merged?
|
|
Ignore the current state of this. I'm just transferring it to my main computer. I'll probably split this into a PR the does all the prep work before splitting and separate ones for each module being split. For the most part the conflicts shouldn't be too bad since git will see basically everything as a rename. Doing this with a sync is probably the best anyways just in case. I'll let @flip1995 make that call since he's the one who has to deal with it. |
Jarcho
removed
the
S-blocked
* Move `declare_clippy_lint` to it's own crate * Move lint/group registration into the driver * Make `dev update_lints` handle multiple lint crates
|
This should be ready now. List of changes:
|
|
r? @Alexendoo |
| [package] | ||
| name = "declare_clippy_lint" | ||
| version = "0.1.89" |
There was a problem hiding this comment.
Should be added to tests/versioncheck.rs
There was a problem hiding this comment.
Probably should. I don't think I added it to clippy_dev either.
| @@ -1,6 +1,7 @@ | |||
| use clippy_config::Conf; | |||
| use clippy_utils::diagnostics::span_lint; | |||
| use clippy_utils::is_from_proc_macro; | |||
| use declare_clippy_lint::declare_clippy_lint; | |||
There was a problem hiding this comment.
We could #[macro_use] the crate to not require lint modules to change, up to you
There was a problem hiding this comment.
I totally forgot that's an option. I personally prefer not having things magically added to a scope, but this is a case where it's not unreasonable.
Based on #14633
The end goal here is to split
clippy_lintsinto several independent crates and have the driver call out to each of them to register lints.clippy_lintstakes way too long to compile right now.r? @flip1995
changelog: none