Add relative_path_in_macro_definition lint (#14472) #14645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement lint to warn about relative `core`/`kernel` paths in macro definitions. Fixes #14472 Signed-off-by: Kunwu Chan <[email protected]> Co-developed-by: Grace Deng <[email protected]> Signed-off-by: Grace Deng <[email protected]>
Create `tests/ui/relative_path_in_macro_definition.rs` with positive and negative cases to verify lint behavior. Signed-off-by: Kunwu Chan <[email protected]> Co-developed-by: Grace Deng <[email protected]> Signed-off-by: Grace Deng <[email protected]>
Add `#![allow(clippy::relative_path_in_macro_definition)]` to `incompatible_msrv.rs`, `swap_ptr_to_ref_unfixable.rs`, and `arithmetic_side_effects.rs` to avoid lint interference. Update corresponding `.stderr` files. Signed-off-by: Kunwu Chan <[email protected]> Co-developed-by: Grace Deng <[email protected]> Signed-off-by: Grace Deng <[email protected]>
rustbot
added
the
S-waiting-on-review
|
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
relative_path_in_macro_definitionlint to warn about relative paths tocoreorkernelin macro definitions, as requested in #14472.Includes tests in
tests/ui/relative_path_in_macro_definition.rsand updates existing tests (incompatible_msrv.rs,swap_ptr_to_ref_unfixable.rs,arithmetic_side_effects.rs) with#![allow]to avoid interference.relative_path_in_macro_definition#14472cargo test,cargo test --test compile-test,cargo test --test integrationcargo fmtclean