-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update book and templates with feature freeze #14456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blyxyas
wants to merge
7
commits into
rust-lang:master
Choose a base branch
from
blyxyas:feature-freeze
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0c05a2
Include temporary feature freeze in book
blyxyas f71d14e
Include temporary feature freeze in templates
blyxyas ca3177c
Move back date 6 weeks
blyxyas dd8d923
Fix remark CI issues
blyxyas 27d00a5
Fix typos in review
blyxyas d369dc2
Add GHA script for feature freeze
blyxyas 6f0fae3
Minor fixes and date correction to book page
blyxyas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# IMPORTANT: FEATURE FREEZE | ||
|
||
This is a temporary notice. | ||
|
||
From May 9th, 2025 until the 1st of August, 2025 we will perform a feature freeze. Only bugfix PRs will be reviewed with the | ||
exception of already open ones. Every feature-adding PR open in between those dates will be moved into a milestone | ||
samueltardieu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
to be reviewed separately at another time. | ||
|
||
We do this because of the long backlog of bugs that need to be addressed | ||
in order to contiue being the state of the art linter that Clippy has become known for being. | ||
|
||
## For contributors | ||
|
||
If you are a contributor or are planning to become one, **please do not open a lint-adding PR**, we have lots of open bugs | ||
of all levels of difficulty that you can address instead! | ||
|
||
We currently have about 800 lints, each one posing a maintainability challenge that needs to account to every possible | ||
usecase of the whole ecosystem. Bugs are natural in every software, but the Clippy team considers that Clippy needs a | ||
refinement period. | ||
|
||
If you open a PR at this time, we will not review it but push it into a milestone until the refinement period ends, | ||
adding additional load into our reviewing schedules. | ||
|
||
## I want to help, what can I do | ||
|
||
Thanks a lot to everyone who wants to help Clippy become better software in this feature freeze period! | ||
If you'd like to help, making a bugfix, making sure that it works, and opening a PR is a great step! | ||
|
||
As a general metric and always taking into account your skill and knowledge level, you can use this guide: | ||
|
||
- 🟥 [ICEs][search_ice], these are compiler errors that causes Clippy to panic and crash. Usually involves high-level debugging, | ||
sometimes interacting directly with the upstream compiler. Difficult to fix but a great challenge that improves | ||
a lot developer workflows! | ||
|
||
- 🟧 [Suggestion causes bug][sugg_causes_bug], Clippy suggested code that changed logic in some silent way. Unacceptable, as this may have | ||
disastreous consequences. Easier to fix than ICEs | ||
|
||
- 🟨 [Suggestion causes error][sugg_causes_error], Clippy suggested code snippet that caused a compiler error when applied. | ||
We need to make sure that Clippy doesn't suggest using a variable twice at the same time or similar | ||
easy-to-happen occurrences. | ||
|
||
- 🟩 [False positives][false_positive], a lint should not have fired, the easiest of them all, as this is "just" identifying the root of a | ||
the false positive and making an exception for those cases. | ||
|
||
Note that false negatives do not have priority unless the case is very clear, as they are a feature-request in a trench coat. | ||
|
||
[search_ice]: https://github.com/rust-lang/rust-clippy/issues?q=sort%3Aupdated-desc+state%3Aopen+label%3A%22I-ICE%22 | ||
[sugg_causes_bug]: https://github.com/rust-lang/rust-clippy/issues?q=sort%3Aupdated-desc%20state%3Aopen%20label%3AI-suggestion-causes-bug | ||
[sugg_causes_error]: https://github.com/rust-lang/rust-clippy/issues?q=sort%3Aupdated-desc%20state%3Aopen%20label%3AI-suggestion-causes-error%20 | ||
[false_positive]: https://github.com/rust-lang/rust-clippy/issues?q=sort%3Aupdated-desc%20state%3Aopen%20label%3AI-false-positive |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.