Skip to content

Add 'CoAP' to doc-valid-idents #13633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Oct 30, 2024

CoAP is a name of a network protocol common in embedded systems; one would talk in documentation about "a CoAP server" or "a CoAP client" without referring to a specific type.

This PR fixes false positives that arise from that use.

changelog: [doc_markdown]: Add CoAP to doc-valid-idents.

As this review is identical in structure to #13460, I'm asking for a the same reviewer (if that works):

r? @Centri3

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
@Centri3
Copy link
Member

Centri3 commented Oct 30, 2024

This seems right in the same ballpark as IPv4 and IPv6 even if less common. I think we could always add stuff like https in the future

@bors r+

@bors
Copy link
Contributor

bors commented Oct 30, 2024

📌 Commit bd4aa17 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 30, 2024

⌛ Testing commit bd4aa17 with merge 1998abc...

@bors
Copy link
Contributor

bors commented Oct 30, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing 1998abc to master...

@bors bors merged commit 1998abc into rust-lang:master Oct 30, 2024
11 checks passed
@chrysn chrysn deleted the doc-valid-ident-coap branch October 31, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants