Skip to content

Rework empty_with_brackets #13063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rework empty_with_brackets #13063

wants to merge 1 commit into from

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 7, 2024 •
edited by llogiq
Loading

This can wait till after #12971. I'm fine with dealing with the merge.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 7, 2024
@llogiq
Copy link
Contributor

llogiq commented Jul 7, 2024

There are dogfood errors. Otherwise this looks ok.

@Jarcho Jarcho force-pushed the empty_brackets branch 2 times, most recently from c45de26 to 9180092 Compare July 7, 2024 15:56
@Jarcho
Rework empty_with_brackets:
787fef0 
* Merge code paths for struct and variants
* Adjust the span to not include leading whitespace
* Don't lint in macros
* Add proc macro detection
* Don't lint if there're comments inside the brackets.
@llogiq
Copy link
Contributor

llogiq commented Jul 17, 2024

Ok, r=me once #12971 landed and this is rebased.

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 17, 2024

✌️ @Jarcho, you can now approve this pull request!

If @llogiq told you to "r=me" after making some further change, please make that change, then do @bors r=@llogiq

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
@y21
Copy link
Member

y21 commented May 17, 2025

#12971 has landed so this should be unblocked now

@Jarcho
Copy link
Contributor Author

Jarcho commented May 17, 2025

Thank you for the reminder. Totally forgot about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jarcho @rustbot @llogiq @bors @y21