Skip to content

configurably allow useless_vec in tests #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Apr 27, 2024

This adds a àllow-useless-vec-in-test configuration which, when set to true will allow the useless_vec lint in #[test] functions and code within #[cfg(test)]. It also moves a is_in_test helper to clippy_utils.


changelog: configurably allow [useless_vec] in test code

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 27, 2024
@llogiq
Copy link
Contributor Author

llogiq commented Apr 28, 2024

Jarcho seems to be busy recently, so perhaps r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Jarcho Apr 28, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Apr 28, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2024

📌 Commit db40ab4 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 28, 2024

⌛ Testing commit db40ab4 with merge 5300d45...

bors added a commit that referenced this pull request Apr 28, 2024
configurably allow `useless_vec` in tests

This adds a `àllow-useless-vec-in-test` configuration which, when set to `true` will allow the `useless_vec` lint in `#[test]` functions and code within `#[cfg(test)]`. It also moves a `is_in_test` helper to `clippy_utils`.

---

changelog: configurably allow [`useless_vec`] in test code
@bors
Copy link
Contributor

bors commented Apr 28, 2024

💔 Test failed - checks-action_test

This adds a `àllow-useless-vec-in-test` configuration which, when set
to `true` will allow the `useless_vec` lint in `#[test]` functions and
code within `#[cfg(test)]`. It also moves a `is_in_test` helper to
`clippy_utils`.
@blyxyas blyxyas force-pushed the allow-useless-test-vecs branch from db40ab4 to 87efce4 Compare April 28, 2024 20:08
@blyxyas
Copy link
Member

blyxyas commented Apr 28, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2024

📌 Commit 87efce4 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 28, 2024

⌛ Testing commit 87efce4 with merge e68fcb0...

@bors
Copy link
Contributor

bors commented Apr 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing e68fcb0 to master...

@bors bors merged commit e68fcb0 into rust-lang:master Apr 28, 2024
8 checks passed
@llogiq llogiq deleted the allow-useless-test-vecs branch April 29, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants