Skip to content

check if closure as method arg has read access in [collection_is_never_read] #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

J-ZhengLi
Copy link
Member

fixes: #11783


changelog: fix [collection_is_never_read] misfires when use retain for iteration

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 19, 2024
@dswij
Copy link
Member

dswij commented Apr 29, 2024

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2024

📌 Commit adab7d0 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 29, 2024

⌛ Testing commit adab7d0 with merge 0fc9a65...

@bors
Copy link
Contributor

bors commented Apr 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 0fc9a65 to master...

@bors bors merged commit 0fc9a65 into rust-lang:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[collection_is_never_read] misfires when using retain for iteration
4 participants