Skip to content

Add cargo dev setup toolchain #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Alexendoo
Copy link
Member

Adds a cargo dev setup toolchain subcommand that creates a rustup toolchain with symlinks to the local cargo-clippy and clippy-driver. Allows you to then do cargo +clippy clippy in other projects to run the locally built Clippy

Sometimes more convenient when you're testing changes on a separate project than cding back & forth to use cargo dev lint [project]

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2024
@Alexendoo Alexendoo force-pushed the cargo-dev-setup-toolchain branch from db8195a to f80400f Compare April 16, 2024 18:07
@Alexendoo Alexendoo force-pushed the cargo-dev-setup-toolchain branch from f80400f to 1fff3be Compare April 16, 2024 18:28
@llogiq
Copy link
Contributor

llogiq commented Apr 17, 2024

There's a lot to unwrap() here, pun intended. I guess for an internal tool that's ok though.

Thank you for building this.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2024

📌 Commit 1fff3be has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 17, 2024

⌛ Testing commit 1fff3be with merge 1ba7821...

@bors
Copy link
Contributor

bors commented Apr 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 1ba7821 to master...

@bors bors merged commit 1ba7821 into rust-lang:master Apr 17, 2024
8 checks passed
@Alexendoo Alexendoo deleted the cargo-dev-setup-toolchain branch April 17, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants