Skip to content

making the default method with no parameters supplied be a single type #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmflight
Copy link

If you don't specify the method when calling ocv_keypoints, it currently fails because there are multiple inputs to the switch statement

# this generates an error, when it really shouldn't
mona <- ocv_read('https://jeroen.github.io/images/monalisa.jpg')
mona <- ocv_resize(mona, width = 320, height = 477)
pts <- ocv_keypoints(mona, method = "FAST")

@jwijffels
Copy link
Contributor

Why not TYPE_9_16?

@rmflight
Copy link
Author

I truly just picked one. I'll be honest, I'm just a user, I haven't followed the literature in this space, I think I just picked the first one in the list to use. If there is a better default, then it should be used instead. I'm fine with changing the default.

@jeroen jeroen force-pushed the master branch 2 times, most recently from 4883ccf to cee9805 Compare April 24, 2023 15:23
@jeroen jeroen force-pushed the master branch 3 times, most recently from 19501e3 to fad1fb3 Compare March 31, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants