Session Replay Transport for Rollbar.js #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltjones
reviewed
May 9, 2025
waltjones
reviewed
May 9, 2025
waltjones
reviewed
May 9, 2025
|
|
||
| recordingSpan.setAttribute('rollbar.replay.id', replayId); | ||
| this.#exporter.export([recordingSpan.span]); | ||
| const spans = spanExportQueue.slice(); |
There was a problem hiding this comment.
The exporter needs a method to map spans in the queue to a payload and return that payload.
There was a problem hiding this comment.
Yes! This is something we need to talk about because I don't fully grasp it, yet.
This is because we don't export the ReadableSpan like we said yesterday, right? We may it into our API payload.
Edit: phone messes up
There was a problem hiding this comment.
Talked offline, will do after this PR.
- Update Queue._handleReplayResponse to return meaningful Promises - Replace setTimeout in tests with async/await for deterministic behavior - Fix replayMap test to properly mock context management and span export queue - Update test expectations to match modern implementation This change maintains backward compatibility while making tests more deterministic and less flaky by using Promises instead of arbitrary timeouts.
- Update _postPromise to use object destructuring for labeled parameters - Replace if/else in callback with ternary operator for more concise code - Maintain backward compatibility with existing code - All tests passing (unit and integration)
matux
force-pushed
the
matux/rrweb-transport
branch
from
093854d to
ffdfeb0
Compare
waltjones
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Description by Claude
Goal
Implement a robust transport mechanism for session replay data in the Rollbar.js SDK by:
Key Components
ReplayMap
Queue Integration
API Extensions
Major Changes
Code Improvements
- Updated Queue._handleReplayResponse to return meaningful Promises
- Improved error handling with explicit return values
- Maintained backward compatibility with existing code
- Fixed context access pattern (contextManager.active() vs context().active())
- Improved span export mechanism to properly integrate with spanExportQueue
- Added robust error handling throughout
Testing Infrastructure
- Separated unit and integration tests into dedicated directories
- Created proper index files for clean imports
- Added dedicated test commands for each test type
- Replaced flaky setTimeout-based assertions with async/await
- Implemented spies on Promise-returning methods to await actual completion
- Created more deterministic test fixtures
- Updated MockTracing to match current implementation
- Improved SpanExporter mock to better simulate actual behavior
- Created precise assertions that verify exact data passed between components
Integration Flow
Benefits of Implementation
This implementation ensures session replay data is correctly associated with errors and reliably transmitted to the Rollbar backend, providing crucial context for debugging production issues.
Type of change
Related issues
Checklists
Development