Skip to content

add option to disable the test controller #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

DetachHead
Copy link
Contributor

fixes #204

@d-biehl
Copy link
Member

d-biehl commented Jan 29, 2024

Thank you for the PR, but I will not merge it in its current state. If you are willing to make further changes and familiarize yourself with the RobotCode code, I would appreciate it. And, of course, I am available for any questions.

@d-biehl
Copy link
Member

d-biehl commented Jan 29, 2024

One more little thing, is it possible that you sign your commits? This brings a little more trust, as RobotCode is used by some companies that are very security conscious and would like to know where the code that is executed on their systems comes from.

See also here:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@DetachHead
Copy link
Contributor Author

If you are willing to make further changes and familiarize yourself with the RobotCode code, I would appreciate it. And, of course, I am available for any questions.

thanks. currently i'm having trouble setting up a local dev environment. i'm trying to use the devcontainer but i can't figure out how to actually build the extension. i tried vsce package and it seemed to work but i don't think it's including everything in the package, because i see this error in the extension's output tab after installing it:

Activate RobotCode Extension.
Try to activate python extension
Python Extension is active
checkRobotVersion: Robot Framework not installed

Robot Framework package not found in workspace folder 'robotcode'. Please install Robot Framework >= version 4.1 to the current python environment or select a valid python environment.
checkRobotVersion: Traceback (most recent call last):
  File "/home/vscode/.vscode-server/extensions/d-biehl.robotcode-0.71.0/bundled/tool/utils/check_robot_version.py", line 30, in <module>
    from robotcode.robot.utils import get_robot_version
ModuleNotFoundError: No module named 'robotcode'

@d-biehl
Copy link
Member

d-biehl commented Feb 3, 2024

Sorry for the late reply, I'm a bit busy at the moment and now RoboCon is coming up. After RoboCon, I will expand the Contribution Guidlines, which will contain all the information you need.

@DetachHead DetachHead force-pushed the disable-testview branch 2 times, most recently from d3b92a0 to ee1a4b3 Compare February 14, 2024 01:08
@DetachHead DetachHead closed this Feb 27, 2024
@DetachHead DetachHead reopened this Feb 27, 2024
@DetachHead
Copy link
Contributor Author

@d-biehl i was able to build it and verify that changing the setting refreshes the test explorer without having to relaunch vscode. i also signed the commit. let me know if there's anything else you want me to change

@d-biehl
Copy link
Member

d-biehl commented Mar 1, 2024

It looks good at first glance, but I won't get round to taking a closer look at it and integrating it until next week. The RoboCon Online

@DetachHead
Copy link
Contributor Author

hi @d-biehl any update on this? currently i'm considering using the new local workspace extensions feature to vendor my fork of the robotcode extension to my team, but it would be nice if this could be merged so i don't have to do that.

sorry if you're still busy, not trying to rush you, just wondering if you'll get around to it soon so i can decide whether it's worth doing this in the mean time or not

@d-biehl d-biehl merged commit 9a8a635 into robotcodedev:main Apr 17, 2024
82 checks passed
@d-biehl
Copy link
Member

d-biehl commented Apr 17, 2024

I have merged your PR and made some corrections, can you test if it works for you?

There is no official release at the moment, because I need to fix something more, but if you can't wait you can get a prelease package by downloading the vcode-package artifact on the latest build_test_package_publish action.

@DetachHead
Copy link
Contributor Author

I have merged your PR and made some corrections, can you test if it works for you?

yeah it still works, thanks

if you can't wait you can get a prelease package by downloading the vcode-package artifact on the latest build_test_package_publish action.

looks like the latest job failed (i think due to flake) so i built it myself instead

@d-biehl
Copy link
Member

d-biehl commented Apr 17, 2024

Yeah, there are some flaky tests, now the build is green 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] option to disable the test controller
2 participants