-
-
Notifications
You must be signed in to change notification settings - Fork 21
add option to disable the test controller #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR, but I will not merge it in its current state. If you are willing to make further changes and familiarize yourself with the RobotCode code, I would appreciate it. And, of course, I am available for any questions. |
One more little thing, is it possible that you sign your commits? This brings a little more trust, as RobotCode is used by some companies that are very security conscious and would like to know where the code that is executed on their systems comes from. See also here: |
df25e56
to
be5771a
Compare
thanks. currently i'm having trouble setting up a local dev environment. i'm trying to use the devcontainer but i can't figure out how to actually build the extension. i tried
|
Sorry for the late reply, I'm a bit busy at the moment and now RoboCon is coming up. After RoboCon, I will expand the Contribution Guidlines, which will contain all the information you need. |
d3b92a0
to
ee1a4b3
Compare
ee1a4b3
to
39e8800
Compare
39e8800
to
734c670
Compare
@d-biehl i was able to build it and verify that changing the setting refreshes the test explorer without having to relaunch vscode. i also signed the commit. let me know if there's anything else you want me to change |
It looks good at first glance, but I won't get round to taking a closer look at it and integrating it until next week. The RoboCon Online |
hi @d-biehl any update on this? currently i'm considering using the new local workspace extensions feature to vendor my fork of the robotcode extension to my team, but it would be nice if this could be merged so i don't have to do that. sorry if you're still busy, not trying to rush you, just wondering if you'll get around to it soon so i can decide whether it's worth doing this in the mean time or not |
014cd5c
to
70a0a73
Compare
I have merged your PR and made some corrections, can you test if it works for you? There is no official release at the moment, because I need to fix something more, but if you can't wait you can get a prelease package by downloading the |
yeah it still works, thanks
looks like the latest job failed (i think due to flake) so i built it myself instead |
Yeah, there are some flaky tests, now the build is green 😎 |
fixes #204