Updates to #112 refactor #122
Conversation
| @@ -65,7 +65,7 @@ the `data` directory; you can access it at `/data/<filename>.json`. | |||
|
|
|||
| ### Available dependencies | |||
|
|
|||
| The repo includes jQuery, Backbone, Underscore, and RequireJS. If there's other | |||
| The repo includes jQuery, Backbone, and Underscore. If there's other | |||
| stuff you'd find useful, you can put it in the `lib` directory. | |||
There was a problem hiding this comment.
might as well get rid of the idea of a lib directory since one does not exist.
There was a problem hiding this comment.
maybe tell people to use npm to add things if they need? they would also have to add the dep to app/runner.html as well as whatever answers they would use it in using node's require.
There was a problem hiding this comment.
I thought about adding that, but decided against adding this to this particular section. It seems to me that the current tools provided are more than enough to solve the current tests.
I could see instructions on adding new tools belonging in the "I don't like this tech stack" / fork this project section, though.
What do you think? 😮
|
There were 3 failing tests. Two are missing answers; the other does work on master. Working to fix it now! |
Updates to #112 refactor
Ready for review/merge!
Updates
To investigate
The following solutions are failing:
logical operatorsyou should be able to work with logical and (✘ This works on master)Fixed!permutation(Solutions missing for two recursion tests js-assessment-answers#33)you should be able to return the nth number in a fibonacci sequenceyou should be able to return the set of all valid combinations of n pairs of parentheses.