update upgrade task status timestamp safely #5317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
force-pushed
the
salah/sc-123136/kots-upgrade-fails-with-panic
branch
from
572169d to
626aa56
Compare
|
Because we don't want the upgrade to fail completely for this transient rqlite error. |
emosbaugh
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates upgrade task status timestamp safely in case of panics so they don't halt the upgrade progress in the UI if rqlite temporarily lost quorum.
Which issue(s) this PR fixes:
SC-123136
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?
NONE