feat(ec): update node join instructions for improved join experience #5304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
previously approved these changes
Apr 28, 2025
|
With step numbers 
|
sgalsaleh
previously approved these changes
Apr 28, 2025
ajp-io
reviewed
Apr 28, 2025
Comment on lines
442
to
443
| "Download the installation assets", | ||
| "Extract the installation assets", |
There was a problem hiding this comment.
Suggested change
| "Download the installation assets", | |
| "Extract the installation assets", | |
| "Download the binary on the new node", | |
| "Extract the binary", |
| @@ -31,7 +31,7 @@ const AddANodeModal = ({ | |||
| {rolesData?.roles && | |||
| rolesData.roles.length > 1 && | |||
| "Select one or more roles to assign to the new node. "} | |||
| Copy the join command and run it on the machine you'd like to join to | |||
| Copy the join commands and run them on the machine you'd like to join to | |||
There was a problem hiding this comment.
just because they're not all join commands
Suggested change
| Copy the join commands and run them on the machine you'd like to join to | |
| Copy the commands and run them on the machine you'd like to join to |
sgalsaleh
approved these changes
Apr 28, 2025
emosbaugh
deleted the
emosbaugh/sc-122566/update-the-kots-ui-to-show-download-untar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Returns a list of commands from the API for the new join experience.
Updates the UI to reflect the new join experience.
Which issue(s) this PR fixes:
SC-122565
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?