Skip to content

Add safe_image_name to help github better track scan findings over time #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

St0rmz1
Copy link
Contributor

@St0rmz1 St0rmz1 commented Apr 25, 2025

What this PR does / why we need it:

  • Add safe_image_name which will eval to something like docker.io-replicated-local-volume-provider, to make it easier for github code scan to track issues. We need to remove the image version from the name.

  • Then when we upload the sarif we set the category to include the new safe image name, which will ensure code scan results are properly tracked by github and will get automatically closed.

  • After this gets merged, I will need to manually kick off the job and then clean out any potential dups or old data from the code scan issues.

Which issue(s) this PR fixes:

NONE

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

…cated-local-volume-provider, to make it easier for github code scan to track issues
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@St0rmz1 St0rmz1 marked this pull request as ready for review April 25, 2025 19:00
@sgalsaleh sgalsaleh merged commit b998072 into main Apr 25, 2025
93 checks passed
@sgalsaleh sgalsaleh deleted the St0rmz1/chore/adjust-code-scan-tracking branch April 25, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants