add hidden 'get join-command' command for embedded-cluster #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check error codes, test error code handling in both requests
laverya
force-pushed
the
laverya/sc-122071/be-able-to-automate-joining-nodes-if-you
branch
from
606f44c to
cba3dab
Compare
sgalsaleh
reviewed
Apr 17, 2025
cmd/kots/cli/get-joincommand.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Println(joinCmd) |
There was a problem hiding this comment.
i think we should also support a -ojson output as people will want to use this command mostly in ci
sgalsaleh
reviewed
Apr 17, 2025
cmd/kots/cli/get-joincommand.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVarP(&format, "output", "o", "string", "Output format. One of: string, json") |
There was a problem hiding this comment.
sorry, but to be consistent with other commands, we should use "" instead of string
There was a problem hiding this comment.
okay - so "" or string gets string output, json gets json output?
There was a problem hiding this comment.
no need for string at all IMO
sgalsaleh
approved these changes
Apr 17, 2025
laverya
deleted the
laverya/sc-122071/be-able-to-automate-joining-nodes-if-you
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?