use EC kinds for the EC node join response, and include the app version #5274
Conversation
| currentAppVersionLabel = appVersion.VersionLabel | ||
| } else { | ||
| // if there are no installed apps, we can't get the current app version label | ||
| logger.Info("no installed apps found") |
There was a problem hiding this comment.
i think this should fail. same if the list of installed apps != 1
There was a problem hiding this comment.
You can join nodes before installing an app - or at least that's my understanding of the sequencing
There was a problem hiding this comment.
the app would be installed at this point. the meaning of installed here is a bit different... it's not that the app got deployed, it means that the license (and airgap bundle) have been processed.
There was a problem hiding this comment.
Gotcha
I'd still rather fall back to "we don't include the app version in the response" instead of "you can't join nodes" though - this is an extra layer of safety check, but far from the only one
| var currentAppVersionLabel string | ||
| // attempt to get the current app version label from the installed app | ||
| installedApps, err := store.GetStore().ListInstalledApps() | ||
| if err == nil && len(installedApps) > 0 { |
There was a problem hiding this comment.
i think you should fail if err != nil here, as that won't fail if there are no apps installed.
laverya
deleted the
laverya/sc-97016/enforce-using-the-same-binary-on-each-node
branch
What this PR does / why we need it:
This uses an imported struct from embedded-cluster for the embedded-cluster node join response, and also includes the current app version label in that response when an app is installed.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?