rename isEmbeddedClusterMultinodeEnabled to isEmbeddedClusterMultiNodeEnabled #5272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
approved these changes
Apr 11, 2025
sgalsaleh
deleted the
salah/sc-121720/respect-the-ec-multi-node-license-option-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bug introduced in most recent versions of KOTS made it so we can't re-use this name to finalize the EC multi node feature. This changes the name so it's treated as a new license field (gets rid of the old one), which allows us to move forward without breaking KOTS.
Which issue(s) this PR fixes:
SC-121720
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?
NONE