Skip to content

use ubuntu-latest instead of ubuntu-20.04 #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/alpha.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:

generate-tag:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend 24.04 and not latest

outputs:
tag: ${{ steps.get_tag.outputs.GIT_TAG }}
steps:
Expand All @@ -25,7 +25,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -39,7 +39,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-migrations:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-migrations-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -59,7 +59,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -73,7 +73,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-kotsadm:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-kotsadm-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -93,7 +93,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -107,7 +107,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-kurl-proxy:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-kurl-proxy-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -122,7 +122,7 @@ jobs:


scan_rqlite:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -149,7 +149,7 @@ jobs:


scan_minio:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -176,7 +176,7 @@ jobs:


scan_dex:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -203,7 +203,7 @@ jobs:


scan_kurl_proxy:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [build-kurl-proxy]
steps:
- name: Checkout
Expand All @@ -226,7 +226,7 @@ jobs:


scan_local_volume_provider:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -253,7 +253,7 @@ jobs:


scan_kotsadm:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [build-kotsadm]
steps:
- name: Checkout
Expand All @@ -276,7 +276,7 @@ jobs:


scan_kotsadm_migrations:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [build-migrations]
steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/image-deps-updater.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
default: 'true'
jobs:
build-3rd-party-images:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:

update-image-deps:
needs: [build-3rd-party-images]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kurl-addon-kots-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency: kurl-addon-publish-${{ inputs.addon_version }}

jobs:
publish-kots-addon:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/kurl-addon-kots-publish
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kurl-addon-kots-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ on:

jobs:
test-kots-addon:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
addon_package_url: ${{ steps.addon-generate.outputs.addon_package_url }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/regression.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

jumpbox:
needs: [get-workspace-name, get-workspace-expiration]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
container:
image: hashicorp/terraform:1.0.11
env:
Expand Down Expand Up @@ -423,7 +423,7 @@ jobs:

cleanup:
needs: [get-workspace-name, tests]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
env:
WORKSPACE: ${{ needs.get-workspace-name.outputs.name }}
steps:
Expand Down
36 changes: 18 additions & 18 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:

jobs:
generate-tag:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
tag: ${{ github.ref_type == 'branch' && steps.get_tag.outputs.GIT_TAG || github.ref_name }}
steps:
Expand All @@ -35,7 +35,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -49,7 +49,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-migrations:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-migrations-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -63,7 +63,7 @@ jobs:
registry-password: ${{ secrets.DOCKERHUB_PASSWORD }}

build-web:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag]
steps:
- name: Checkout
Expand All @@ -88,7 +88,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -102,7 +102,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-kurl-proxy:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-kurl-proxy-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -116,7 +116,7 @@ jobs:
registry-password: ${{ secrets.DOCKERHUB_PASSWORD }}

build-kots:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [build-web, generate-tag]
steps:
- uses: actions/setup-go@v5
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
fail-fast: true
matrix:
runner: [
{name: ubuntu-20.04, arch: amd64},
{name: ubuntu-latest, arch: amd64},
{name: arm64-runner-set, arch: arm64}
]
runs-on: ${{ matrix.runner.name }}
Expand All @@ -169,7 +169,7 @@ jobs:
arch: ${{ matrix.runner.arch }}

build-kotsadm:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-kotsadm-melange-packages]
steps:
- uses: actions/checkout@v4
Expand All @@ -183,7 +183,7 @@ jobs:
registry-password: ${{ secrets.DOCKERHUB_PASSWORD }}

build-kotsadm-bundle:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag, build-migrations, build-kotsadm]
steps:
- name: Checkout
Expand Down Expand Up @@ -227,7 +227,7 @@ jobs:
path: kotsadm-bundle-nominio

goreleaser:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: github.ref_type != 'branch'
needs: [generate-tag, build-web]
steps:
Expand Down Expand Up @@ -283,7 +283,7 @@ jobs:
GORELEASER_CURRENT_TAG: ${{ needs.generate-tag.outputs.tag }}

publish-pact-contracts:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [ generate-tag, goreleaser ]
steps:
- uses: actions/checkout@v4
Expand All @@ -303,7 +303,7 @@ jobs:
make pact-consumer

generate-kurl-addon:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [ generate-tag, build-kurl-proxy, build-kots, build-kotsadm-bundle ]
outputs:
addon_package_url: ${{ steps.addon-generate.outputs.addon_package_url }}
Expand Down Expand Up @@ -337,7 +337,7 @@ jobs:

# only run validate-kurl-addon if changes to "deploy/kurl/kotsadm/template/**"
kurl-addon-changes-filter:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
ok-to-test: ${{ steps.filter.outputs.kurl-addon }}
steps:
Expand All @@ -351,7 +351,7 @@ jobs:
- 'deploy/kurl/kotsadm/testgrid-os-spec.yaml'

validate-kurl-addon:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ github.ref_type != 'branch' || needs.kurl-addon-changes-filter.outputs.ok-to-test == 'true' }}
needs: [ generate-tag, generate-kurl-addon, kurl-addon-changes-filter ]
steps:
Expand All @@ -370,7 +370,7 @@ jobs:
testgrid_api_token: ${{ secrets.TESTGRID_PROD_API_TOKEN }}

publish-kurl-addon:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ github.ref_type != 'branch' }}
needs: [ generate-tag, generate-kurl-addon ]
env:
Expand All @@ -393,7 +393,7 @@ jobs:
- run: aws s3 cp ./deploy/kurl/versions.json s3://kots-kurl-addons-production-1658439274

generate-kots-release-notes-pr:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [generate-tag]
if: github.ref_type != 'branch'
steps:
Expand All @@ -411,7 +411,7 @@ jobs:
"https://api.github.com/repos/replicatedhq/replicated-docs/dispatches"

build-airgap:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: github.ref_type != 'branch'
needs: [goreleaser, generate-tag, build-kotsadm-bundle]
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tag-helm-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
tag-helm-chart:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: github.event.action == 'released'
steps:
- name: Checkout Chart
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-kubectl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
build-pr-kubectl:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
Expand Down
Loading