Skip to content

Chore - refactor image scanning process #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2025
Merged

Chore - refactor image scanning process #5247

merged 9 commits into from
Mar 31, 2025

Conversation

St0rmz1
Copy link
Contributor

@St0rmz1 St0rmz1 commented Mar 28, 2025

What this PR does / why we need it:

Enhancements to the daily image scanning process

  • file and job name changes for clarity
  • added input validations
  • the reusable workflow now creates a sarif even if no vulns detected. This is so external tools will always have a recent file to pull for reporting.

St0rmz1/chore/refactor scanning

Which issue(s) this PR fixes:

NONE

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

St0rmz1 added 2 commits March 28, 2025 13:28
@St0rmz1
rename
8049a41 
add validations of inputs
handle case if sarif cannot be created from grype, then we create one anyway
this way the reporting systems will always have a recent sarif to use
@St0rmz1
add inputs required by the reusable workflow
09a5958
@St0rmz1 St0rmz1 marked this pull request as ready for review March 28, 2025 21:43
emosbaugh
emosbaugh reviewed Mar 31, 2025
View reviewed changes
@St0rmz1 @emosbaugh
Update .github/workflows/scan-image-grype.yml
4370dbd 
good catch

Co-authored-by: Ethan Mosbaugh <[email protected]>
@St0rmz1 St0rmz1 marked this pull request as draft March 31, 2025 15:57
@St0rmz1 St0rmz1 marked this pull request as ready for review March 31, 2025 18:56
@St0rmz1 St0rmz1 merged commit 95a0b8c into main Mar 31, 2025
95 checks passed
@St0rmz1 St0rmz1 deleted the St0rmz1/chore/refactor-scanning branch March 31, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emosbaugh emosbaugh emosbaugh approved these changes

Assignees

@laverya laverya

Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@St0rmz1 @emosbaugh @laverya