fix edit config link on dashboard #4564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
commented
Apr 22, 2024
| @@ -148,7 +147,7 @@ export default class AppStatus extends Component<Props, State> { | |||
| </> | |||
| )} | |||
| <Link | |||
| to={`${url}/config/${app?.downstream?.currentVersion?.sequence}`} | |||
There was a problem hiding this comment.
I'm not aware of a scenario where this was not undefined, so I just removed it all together. Tested this with both single and multi-app installs and both render the correct link for editing config.
sgalsaleh
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where the url for the "Edit Config" link on the dashboard was invalid and contained an
undefinedreference.Which issue(s) this PR fixes:
Fixes SC-102656
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE