pass embedded cluster artifacts in upstream upgrade #4549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodonnell
force-pushed
the
cbo/sc-101432/upstream-upgrade-embedded-artifacts
branch
from
b9a3b7a to
c4efeb3
Compare
cbodonnell
force-pushed
the
cbo/sc-101432/upstream-upgrade-embedded-artifacts
branch
from
3c98dc6 to
0c9cefb
Compare
cbodonnell
commented
Apr 15, 2024
Comment on lines
-119
to
-126
|
|
||
| if err := image.UpdateInstallationEmbeddedClusterArtifacts(image.UpdateInstallationEmbeddedClusterArtifactsOptions{ | ||
| Artifacts: copyResult.EmbeddedClusterArtifacts, | ||
| KotsKinds: opts.KotsKinds, | ||
| UpstreamDir: opts.UpstreamDir, | ||
| }); err != nil { | ||
| return nil, errors.Wrap(err, "failed to update installation airgap artifacts") | ||
| } |
There was a problem hiding this comment.
We don't need to write back to the installation.yaml anymore with push results since we're just using what is in the airgap metadata.
sgalsaleh
approved these changes
Apr 16, 2024
cbodonnell
deleted the
cbo/sc-101432/upstream-upgrade-embedded-artifacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies code paths associated with the
upstream upgradeCLI command to to ensure that embedded cluster artifacts from the airgap metadata are persisted in the installation file. This helps enable airgap upgrades from the CLI in embedded clusters.Enables automated airgap upgrade testing of: https://app.shortcut.com/replicated/story/101432/trigger-airgap-upgrade-from-kots
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?