Skip to content

consider PendingChartCreation state during upgrade ui #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/src/utilities/utilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,8 @@ export const Utilities = {
const normalizedState = this.clusterState(cluster.state);
if (
normalizedState === "Upgrading" ||
normalizedState === "Upgrading addons"
normalizedState === "Upgrading addons" ||
normalizedState === "Creating addons"
) {
return true;
}
Expand Down
32 changes: 20 additions & 12 deletions web/src/utilities/utilities.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,28 @@ describe("Utilities", () => {
});

it("should return true if the user has tried to deploy the current version and a cluster upgrade is in progress", () => {
const apps = [
{
downstream: {
currentVersion: {
status: "deployed",
},
cluster: {
requiresUpgrade: true,
state: "Installing",
for (const installationState of [
"CopyingArtifacts",
"Enqueued",
"Installing",
"AddonsInstalling",
"PendingChartCreation",
]) {
const apps = [
{
downstream: {
currentVersion: {
status: "deployed",
},
cluster: {
requiresUpgrade: true,
state: installationState,
},
},
},
},
];
expect(Utilities.shouldShowClusterUpgradeModal(apps)).toBe(true);
];
expect(Utilities.shouldShowClusterUpgradeModal(apps)).toBe(true);
}
});

it("should return false if there are is one installation that does not have a state", () => {
Expand Down
Loading