feat(troubleshoot): support for distribution kind #4539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
force-pushed
the
emosbaugh/sc-102282/distribution-analyzer-should-support-kind
branch
2 times, most recently
from
ab9b00d to
7837ec1
Compare
emosbaugh
force-pushed
the
emosbaugh/sc-102282/distribution-analyzer-should-support-kind
branch
from
95833aa to
c671bbd
Compare
emosbaugh
commented
Apr 8, 2024
go.mod
Outdated
Comment on lines
432
to
436
| // This is the only way I could get these two to play nice together | ||
| replace ( | ||
| github.com/replicatedhq/troubleshoot => github.com/replicatedhq/troubleshoot v0.86.0 | ||
| github.com/vmware-tanzu/velero => github.com/vmware-tanzu/velero v1.10.0-rc.1.0.20240408090904-54462c4f7bb5 | ||
| ) |
emosbaugh
commented
Apr 8, 2024
| @@ -11,8 +11,8 @@ import ( | |||
|
|
|||
| "github.com/containers/image/v5/pkg/docker/config" | |||
| "github.com/containers/image/v5/types" | |||
| "github.com/distribution/distribution/v3/registry/client/auth/challenge" | |||
There was a problem hiding this comment.
this package is now internal
There was a problem hiding this comment.
what's the reason behind needing to make this one internal?
There was a problem hiding this comment.
github.com/distribution/distribution has made it internal so we can no longer import it
cbodonnell
approved these changes
Apr 8, 2024
emosbaugh
deleted the
emosbaugh/sc-102282/distribution-analyzer-should-support-kind
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades the troubleshoot package with kind support for distribution analyzer to better support all CMX distros.
Which issue(s) this PR fixes:
Fixes #
[sc-102282]
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?