CLI flag and password prompt improvements #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
ajp-io
force-pushed
the
alexparker/sc-104449/make-it-clear-you-re-setting-the-admin-console
branch
from
b2ab104 to
4405010
Compare
ajp-io
force-pushed
the
alexparker/sc-104449/make-it-clear-you-re-setting-the-admin-console
branch
from
4405010 to
6f41736
Compare
ajp-io
changed the title
ajp-io
changed the title
sgalsaleh
reviewed
Jul 11, 2024
| Name: "no-prompt", | ||
| Usage: "Disable interactive prompts. The Admin Console password will be set to password.", | ||
| Value: false, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "no-proxy", |
There was a problem hiding this comment.
should this flag be right below the http-proxy and https-proxy flags?
There was a problem hiding this comment.
I considered grouping those together but did it alphabetically, which seems fairly standard.
sgalsaleh
approved these changes
Jul 11, 2024
ajp-io
deleted the
alexparker/sc-104449/make-it-clear-you-re-setting-the-admin-console
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--admin-console-passwordflag toinstall