fix(install): keep a single instance of runtime config within the API context #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
|
Opted for parking this for now until we get a bit more clarity in terms of how we want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses something that came up once I rebased - #2226
See the failure:
This failure is a consequence of how we're currently passing around the runtime config between controller, managers, etc. This doesn't surface in production because we let the install controller instantiate everything, however I'm worried we might run into this in the future with the way we have our structs wired up. The idea here is that instead of keeping a runtime config property in multiple places that can lead to a disconnect between which instance is being used, we keep one copy of it at the controller level and pass it around to all the manager methods when they need it. We could eventually look into either keeping the runtime config in a specific manager (Installation?) or creating its dedicated manager (overkill?) but I believe that for now this should suffice.
Which issue(s) this PR fixes:
Does this PR require a test?
Updated
Does this PR require a release note?
Does this PR require documentation?
NONE