Skip to content

Address feedback from new API preflights PR #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025

Conversation

sgalsaleh
Copy link
Member

What this PR does / why we need it:

Addresses some of the feedback from this this PR: #2234

Which issue(s) this PR fixes:

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

JGAntunes
JGAntunes previously approved these changes Jun 6, 2025
Copy link

github-actions bot commented Jun 6, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-6f80c0b" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-6f80c0b?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@sgalsaleh
Copy link
Member Author

Merging as failing test is falky.

@sgalsaleh sgalsaleh merged commit d0db045 into main Jun 7, 2025
122 of 127 checks passed
@sgalsaleh sgalsaleh deleted the address-feedback-from-preflights-pr branch June 7, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants