Fix prompts showing before required flag errors #2219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, when users run the install command with missing required flags (like --license), they may be prompted for optional values (like creating an admin console password if one was not provided through the --admin-console-password flag) before seeing validation errors. This creates a frustrating experience where users complete prompts unnecessarily.
This PR moves the
preRunInstall
call from cobra'sPreRunE
toRunE
to get the following order of execution and give precedence to required flag errorsCurrent Behavior
PreRunE
preRunInstall (prompts happen here)
Cobra's flag validation
RunE
New Behavior
PreRunE(removed, preRunInstall was the only thing in it)Cobra's flag validation
RunE
preRunInstall (prompts happen here)
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/124248/cli-install-command-shows-prompts-before-required-flag-validation-errors
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE