-
Notifications
You must be signed in to change notification settings - Fork 5
chore(api): add tests to the install endpoints #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if err := c.installationManager.ValidateStatus(status); err != nil { | ||
return fmt.Errorf("validate: %w", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be doing some follow up PRs that test the validations on the installationManager
7858fb0
to
32afb27
Compare
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
32afb27
to
4a721f6
Compare
Had to address conflicts, could I get another ✅ @emosbaugh @sgalsaleh |
What this PR does / why we need it:
Follow up from:
See comment:
Adds tests to our
install/status
andinstall/config
endpoints.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/124213/add-integration-tests-to-our-install-endpoints
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?