Skip to content

chore(api): add tests to the install endpoints #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

Conversation

JGAntunes
Copy link
Member

What this PR does / why we need it:

Follow up from:

See comment:

Adds tests to our install/status and install/config endpoints.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/124213/add-integration-tests-to-our-install-endpoints

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

@JGAntunes JGAntunes requested a review from sgalsaleh May 29, 2025 16:36
@JGAntunes JGAntunes self-assigned this May 29, 2025
@JGAntunes JGAntunes requested a review from emosbaugh May 29, 2025 16:37
Comment on lines +91 to +93
if err := c.installationManager.ValidateStatus(status); err != nil {
return fmt.Errorf("validate: %w", err)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be doing some follow up PRs that test the validations on the installationManager

sgalsaleh
sgalsaleh previously approved these changes May 29, 2025
@JGAntunes JGAntunes force-pushed the chore/test-install branch from 7858fb0 to 32afb27 Compare May 29, 2025 16:46
emosbaugh
emosbaugh previously approved these changes May 29, 2025
Copy link

github-actions bot commented May 30, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-5788c2d" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-5788c2d?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@JGAntunes JGAntunes dismissed stale reviews from emosbaugh and sgalsaleh via 4a721f6 May 30, 2025 10:17
@JGAntunes JGAntunes force-pushed the chore/test-install branch from 32afb27 to 4a721f6 Compare May 30, 2025 10:17
@JGAntunes JGAntunes requested review from emosbaugh and sgalsaleh May 30, 2025 10:17
@JGAntunes
Copy link
Member Author

Had to address conflicts, could I get another ✅ @emosbaugh @sgalsaleh

@JGAntunes JGAntunes merged commit 16b888f into main May 30, 2025
183 of 190 checks passed
@JGAntunes JGAntunes deleted the chore/test-install branch May 30, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants