chore(api): add tests to the install endpoints #2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
commented
May 29, 2025
Comment on lines
+91
to
+93
| if err := c.installationManager.ValidateStatus(status); err != nil { | ||
| return fmt.Errorf("validate: %w", err) | ||
| } |
There was a problem hiding this comment.
I'll be doing some follow up PRs that test the validations on the installationManager
sgalsaleh
previously approved these changes
May 29, 2025
JGAntunes
force-pushed
the
chore/test-install
branch
from
7858fb0 to
32afb27
Compare
emosbaugh
previously approved these changes
May 29, 2025
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
JGAntunes
force-pushed
the
chore/test-install
branch
from
32afb27 to
4a721f6
Compare
|
Had to address conflicts, could I get another ✅ @emosbaugh @sgalsaleh |
sgalsaleh
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up from:
See comment:
Adds tests to our
install/statusandinstall/configendpoints.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/124213/add-integration-tests-to-our-install-endpoints
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?