Run playwright test on CMX node #2206
Open
+359
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
previously approved these changes
May 28, 2025
| return nil | ||
| } | ||
|
|
||
| func (c *Cluster) SetupPlaywright(envs ...map[string]string) error { |
There was a problem hiding this comment.
any reason why BypassKurlProxy isnt part of SetupPlaywright?
There was a problem hiding this comment.
yes, because we need to setup playwright before airgapping the nodes as it needs internet access and kubernetes (kubectl) isn't available in at that point so bypassing kurl proxy has to happen separately.
sgalsaleh
force-pushed
the
run-playwright-on-cmx-node
branch
from
1889777 to
d3729bd
Compare
sgalsaleh
force-pushed
the
run-playwright-on-cmx-node
branch
from
d3729bd to
c68c15e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CMX port forwarder has a very high latency causing our tests to timeout. This PR makes it so that we run the Playwright test on the CMX node itself.
Which issue(s) this PR fixes:
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE