fix: empty tmp dir instead of removing it #2203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tmp directory is used for a number of things including when editig k8s resources using kubectl edit. Removing it after running commands will lead to failures in certain commands. Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
sgalsaleh
reviewed
May 28, 2025
pkg/runtimeconfig/runtimeconfig.go
Outdated
| @@ -27,7 +27,23 @@ func Get() *ecv1beta1.RuntimeConfigSpec { | |||
| } | |||
|
|
|||
| func Cleanup() { | |||
| os.RemoveAll(EmbeddedClusterTmpSubDir()) | |||
| emptyTmpDir() | |||
There was a problem hiding this comment.
we already have helpers.RemoveAll. can you please use that instead? it also has tests
Signed-off-by: Evans Mungai <[email protected]>
banjoh
force-pushed
the
evansmungai/sc-124106/collecting-a-support-bundle-deletes-tmp-directory
branch
from
0c0d7fb to
181dce8
Compare
Signed-off-by: Evans Mungai <[email protected]>
sgalsaleh
approved these changes
May 28, 2025
|
Merging as change is unrelated and tests are flaky right now. |
sgalsaleh
deleted the
evansmungai/sc-124106/collecting-a-support-bundle-deletes-tmp-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
tmpdirectory is used for a number of things including when edittig k8s resources usingkubectl edit. Removing it after running commands will lead to failures in certain situations.Which issue(s) this PR fixes:
sc-124106
Does this PR require a test?
Unit test added
Does this PR require a release note?
Does this PR require documentation?
NONE