-
Notifications
You must be signed in to change notification settings - Fork 5
fix(api-client): addresses bugs in API client #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-client): addresses bugs in API client #2191
Conversation
type APIError struct { | ||
StatusCode int `json:"status_code"` | ||
Message string `json:"message"` | ||
} | ||
|
||
func (e *APIError) Error() string { | ||
return fmt.Sprintf("status=%d, message=%q", e.StatusCode, e.Message) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leverage types.APIError
instead.
Token string `json:"token"` | ||
} | ||
err = json.NewDecoder(resp.Body).Decode(&loginResp) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
c.token = loginResp.SessionToken | ||
c.token = loginResp.Token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching the API response body.
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
Merging into a branch |
c64fd9b
into
salah/sc-123874/steelthread-configure-data-dir-in-the-new
What this PR does / why we need it:
This PR branches out of:
Adds tests to the API client and fixes the underlying bugs found as part of it.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?