fix(api-client): addresses bugs in API client #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
commented
May 27, 2025
Comment on lines
-12
to
-19
| type APIError struct { | ||
| StatusCode int `json:"status_code"` | ||
| Message string `json:"message"` | ||
| } | ||
|
|
||
| func (e *APIError) Error() string { | ||
| return fmt.Sprintf("status=%d, message=%q", e.StatusCode, e.Message) | ||
| } |
There was a problem hiding this comment.
We can leverage types.APIError instead.
JGAntunes
commented
May 27, 2025
Comment on lines
+39
to
+46
| Token string `json:"token"` | ||
| } | ||
| err = json.NewDecoder(resp.Body).Decode(&loginResp) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| c.token = loginResp.SessionToken | ||
| c.token = loginResp.Token |
There was a problem hiding this comment.
Matching the API response body.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
approved these changes
May 27, 2025
sgalsaleh
approved these changes
May 27, 2025
|
Merging into a branch |
sgalsaleh
merged commit c64fd9b
into
salah/sc-123874/steelthread-configure-data-dir-in-the-new
58 of 63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR branches out of:
Adds tests to the API client and fixes the underlying bugs found as part of it.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?