chore(api-error): change unauthorized msg and add tests #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
previously approved these changes
May 27, 2025
sgalsaleh
previously approved these changes
May 27, 2025
|
Merging into a branch. |
sgalsaleh
force-pushed
the
salah/sc-123874/steelthread-configure-data-dir-in-the-new
branch
2 times, most recently
from
ec30def to
50ef28e
Compare
Base automatically changed from
salah/sc-123874/steelthread-configure-data-dir-in-the-new
to
main
May 27, 2025 18:35
sgalsaleh
dismissed stale reviews from emosbaugh and themself
The base branch was changed.
JGAntunes
force-pushed
the
chore/api-errors
branch
from
1ce3d26 to
f4060de
Compare
|
I don't think this has been merged @sgalsaleh. Rebased with main, so should be good to 👀 and ✅ |
JGAntunes
commented
May 28, 2025
| @@ -57,7 +57,7 @@ func NewBadRequestError(err error) *APIError { | |||
| func NewUnauthorizedError(err error) *APIError { | |||
| return &APIError{ | |||
| StatusCode: http.StatusUnauthorized, | |||
| Message: err.Error(), | |||
| Message: "Unauthorized", | |||
There was a problem hiding this comment.
When dealing with 401's we shouldn't be exposing any context around what happened.
emosbaugh
approved these changes
May 28, 2025
|
Test failures seem unrelated. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Story: https://app.shortcut.com/replicated/story/124146/add-tests-to-api-error-types
Adds tests to
api/types/errors_test.goand changes the Unauthorized API error to not expose the underlyingerr.Error()throughMessage.Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?