feat: add prompt to proceed if http proxy is set and https proxy unset #2186
+83
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
ajp-io
reviewed
May 28, 2025
| @@ -99,6 +101,20 @@ func getProxySpec(cmd *cobra.Command) (*ecv1beta1.ProxySpec, error) { | |||
| } | |||
| } | |||
|
|
|||
| // Check if user only provided HTTP proxy but not HTTPS proxy | |||
| if httpProxy != "" && httpsProxy == "" { | |||
| message := "Typically if `http_proxy` is set, `https_proxy` should be set too. Installation failures are likely otherwise. Do you want to continue anyway?" | |||
There was a problem hiding this comment.
Suggested change
| message := "Typically if `http_proxy` is set, `https_proxy` should be set too. Installation failures are likely otherwise. Do you want to continue anyway?" | |
| message := "Typically --https-proxy should be set if --http-proxy is set. Installation failures are likely otherwise. Do you want to continue anyway?" |
There was a problem hiding this comment.
looking at your loom, this prints out before the message about a required flag (--license) missing. generally i think errors due to missing flags should be shown first since this is an informational warning that someone could ignore. so i would prefer for this check to occur after the required flags are looked at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Installation fails if
http_proxyis configured buthttps_proxyis not set.This PR adds the following confirmation prompt before proceeding with an installation:
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/121629/prompt-if-http-proxy-is-set-but-not-https-proxy
Does this PR require a test?
Unit tests have been added to verify:
http_proxyset withouthttps_proxyand user confirms (inputs y) proceeding with installationhttp_proxyset withouthttps_proxyand user declines (inputs n) proceeding with installationDoes this PR require a release note?
Does this PR require documentation?
NONE