Skip to content

feat: Add prompt to proceed if http proxy is set and https proxy unset #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

screspod
Copy link
Member

What this PR does / why we need it:

Installation fails if http_proxy is configured but https_proxy is not set.
This PR adds the following confirmation prompt before proceeding with an installation:

Typically if `http_proxy` is set, `https_proxy` should be set too. Installation failures are likely otherwise. Do you want to continue anyway? (y/N)

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/121629/prompt-if-http-proxy-is-set-but-not-https-proxy

Does this PR require a test?

Unit tests have been added to verify:

  • When a vendor confirms they want to continue the installation with http_proxy set and https_proxy unset.
  • When a vendor confirms they DO NOT want to continue the installation with http_proxy set and https_proxy unset.

Does this PR require a release note?

Added confirmation prompt to prevent installation failures when `http_proxy` is set but `https_proxy` is missing.

Does this PR require documentation?

NONE

@screspod screspod force-pushed the 121629/prompt-if-https-proxy-unset branch from 08d0640 to 909c56b Compare May 22, 2025 23:00
@screspod screspod changed the title Add prompt to proceed if http proxy is set and https proxy unset faet: add prompt to proceed if http proxy is set and https proxy unset May 22, 2025
@screspod screspod changed the title faet: add prompt to proceed if http proxy is set and https proxy unset faet: Add prompt to proceed if http proxy is set and https proxy unset May 22, 2025
@screspod screspod changed the title faet: Add prompt to proceed if http proxy is set and https proxy unset feat: Add prompt to proceed if http proxy is set and https proxy unset May 22, 2025
@screspod screspod closed this May 23, 2025
@screspod
Copy link
Member Author

Closing this. Opened from a fork which led to a lack of access to credentials necessary for the Github actions to run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant