chore(e2e): create multiple VMs in one go through the CLI #2181
Conversation
|
|
||
| args := []string{ | ||
| "vm", "create", | ||
| "--name", nodeName, | ||
| "--network", networkID, | ||
| "--name", "ec-test-suite", |
There was a problem hiding this comment.
Since we're creating multiple nodes now they'll all gonna have the same name, I've replaced the ID in most of the logs in here and also added a couple of initial log lines post cluster creation that maps the index in the Nodes slice to the node ID and private IP. This is how it looks:
cluster.go:64: creating 3 nodes
cluster.go:136: node 0 created with ID b8309fa6 and private IP 10.0.0.247
cluster.go:136: node 1 created with ID 1a08d35f and private IP 10.0.0.192
cluster.go:136: node 2 created with ID 5054f8b6 and private IP 10.0.0.229
cluster.go:56: cluster created with network ID 624bf1704b41342375aa887fcce206124bfbd01da194720556d06976ec9f435f
restore_test.go:649: 2025-05-22T12:46:48+01:00: deploying minio on node 0
restore_test.go:655: 2025-05-22T12:49:16+01:00: downloading airgap files
airgap.go:92: downloaded airgap bundle on node 0 to /assets/ec-release.tgz (2.0 GB) in 1m17.617605375s
airgap.go:92: downloaded airgap bundle on node 0 to /assets/ec-release-upgrade.tgz (2.1 GB) in 1m21.8185815s
restore_test.go:668: 2025-05-22T12:50:37+01:00: installing expect package on node 0
restore_test.go:673: 2025-05-22T12:50:42+01:00: installing expect package on node 2
restore_test.go:678: 2025-05-22T12:50:46+01:00: airgapping cluster
cluster.go:236: node 0 is airgapped successfully
cluster.go:236: node 1 is airgapped successfully
cluster.go:236: node 2 is airgapped successfully
There was a problem hiding this comment.
is it ok that all workflow runs will have the same name?
There was a problem hiding this comment.
I would imagine it's fine since we do all the operations based on node IDs, it's also not that different from having multiple runs using `node0´ for example.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
|
Just heads up, this does not help with the "host unreachable"/"No route to host" error. We should have a fix for that soon though. |
JGAntunes
dismissed
sgalsaleh’s stale review
The merge-base changed after approval.
JGAntunes
force-pushed
the
chore/cmx-e2e-multiple-hosts
branch
from
ba88a0a to
ea640f8
Compare
JGAntunes
force-pushed
the
chore/cmx-e2e-multiple-hosts
branch
from
ea640f8 to
a3634fc
Compare
JGAntunes
force-pushed
the
chore/cmx-e2e-multiple-hosts
branch
from
a3634fc to
fe8a299
Compare
|
|
||
| args := []string{ | ||
| "vm", "create", | ||
| "--name", nodeName, | ||
| "--network", networkID, | ||
| "--name", "ec-test-suite", |
There was a problem hiding this comment.
is it ok that all workflow runs will have the same name?
What this PR does / why we need it:
Based on the following thread:
Seems like a lot of the E2E test flakiness and errors we've been getting with CMX can be addressed if instead of manually creating the network and each node in parallel we leverage the VM API and create all the required VMs in one go (which will be under the same network by default).
Which issue(s) this PR fixes:
NA
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE