Skip to content

add retries to leaveEtcdcluster #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

laverya
Copy link
Member

@laverya laverya commented Apr 7, 2025

What this PR does / why we need it:

        error: unable to leave etcd cluster: exit status 1: {"level":"warn","ts":"2025-04-05T12:39:27.465388Z","logger":"etcd-client","caller":"[email protected]/retry_interceptor.go:63","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc000830000/127.0.0.1:2379","attempt":0,"error":"rpc error: code = Unavailable desc = etcdserver: server stopped"}
        time="2025-04-05 12:39:27" level=error msg="Failed to delete node from cluster" peerID=314ee8343a8b0c36 peerURL="https://172.17.0.4:2380"
        Error: etcdserver: server stopped

This isn't desirable.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

Copy link

github-actions bot commented Apr 7, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-7ffa674" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-7ffa674?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@laverya laverya marked this pull request as ready for review April 7, 2025 18:43
if err != nil {
return err
logrus.Warnf("Unable to list etcd members, continuing with reset: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this used to return an error before, is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - we can still reset the actual node at that point and so we should

@laverya laverya enabled auto-merge (squash) April 7, 2025 20:28
@laverya laverya merged commit 33bb2e3 into main Apr 7, 2025
66 checks passed
@laverya laverya deleted the laverya/sc-115847/don-t-error-on-reset-when-nothing-was-wrong branch April 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants