Adding License Testing for Tiered Storage #233
Merged
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
force-pushed
the
license-work
branch
from
594c9a2 to
c367818
Compare
gene-redpanda
force-pushed
the
license-work
branch
from
c367818 to
ba1d725
Compare
ivotron
requested review from
a team and
gousteris
and removed request for
a team
RafalKorepta
approved these changes
Dec 3, 2024
rpdevmp
approved these changes
Dec 3, 2024
hcoyote
reviewed
Dec 3, 2024
| tasks: | ||
| - name: Check cluster health | ||
| ansible.builtin.shell: | | ||
| {{ rpk_bin }} cluster health | grep -i 'healthy:' | tr -d '[:space:]' | awk -F ':' '{print tolower($2)}' |
There was a problem hiding this comment.
Probably better to do something like this and check the return code of grep, rather than trying to parse out the true/false status.
rpk cluster health | grep -q -i 'healthy.*false'
returns 0 if one or more lines matched the regex. returns 1 if zero lines matched.
There was a problem hiding this comment.
(though, it would be better if rpk cluster health set a return code of 0 or 1 depending on cluster health state, then we could check the return code directly -- don't think that support exists right now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an operation to apply license separately + testing related to it.