Skip to content

Fix imports #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Fix imports #2929

merged 3 commits into from
Apr 30, 2025

Conversation

nkaradzhov
Copy link
Collaborator

@nkaradzhov nkaradzhov commented Apr 29, 2025

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested? -> N/A
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

align exports with v4 as much as possible
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the import issues by updating and uncommenting several export statements to improve module accessibility and consistency.

  • Updated exports in the time-series, search, redis, and client packages.
  • Revised the documentation in docs/v4-to-v5.md to reflect renamed constants and exports.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/time-series/lib/index.ts Added export for TIME_SERIES_REDUCERS from MRANGE_GROUPBY module.
packages/search/lib/index.ts Updated various exports from commands to align with new naming conventions.
packages/redis/index.ts Uncommented exports to expose modules from redis packages.
packages/client/index.ts Uncommented error exports and updated command exports for GEO_REPLY_WITH and REDIS_FLUSH_MODES.
docs/v4-to-v5.md Updated documentation to reflect the new export names.

@nkaradzhov nkaradzhov requested review from htemelski and removed request for htemelski April 29, 2025 17:13
return SetOptions export
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkaradzhov nkaradzhov merged commit 048df30 into redis:master Apr 30, 2025
11 checks passed
@nkaradzhov nkaradzhov deleted the fix-imports branch April 30, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants