[CAE-342] Initial sentinel issues fix #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaradzhov
approved these changes
Apr 8, 2025
bobymicroby
requested changes
Apr 28, 2025
bobymicroby
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a couple of issues with the sentinel implementation
maxCommandRediscoverswatchstatus if there are multiple topology changes during a transaction.withTypeMapping()methodFixed an issue with the testing setup itself, using the new docker image and setting the
requirepassandmasterauthconfiguration settings in a persistent way.Enabled the majority of sentinel tests, added new test for fix 1.
Still skipping some tests that are flaky and prone to failing
Checklist
npm testpass with this change (including linting)?